Refs/heads/codexfix failing workflows in sei chain repo #2410
Conversation
…ting Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…tegration-tests Add conditional Slinky integration test
Potential fix for code scanning alert no. 422: Potentially unsafe quoting
…caching Improve CI workflows
…y-seikinsettlement-and-circlecciprouter-contracts
…d-circlecciprouter-contracts Add SeiKin settlement and Circle CCIP router contracts
…re-seikinsettlement-for-deployment
…ion-module Add Holo Protocol demo package and sync workflow
…or-deployment Add SeiKinSettlement protocol contract
…tion-errors Add Kin pulse and handoff verifier contracts
…-and-seiccipmessagedecoder-modules Add Kin royalty router, CCIP decoder, vault scanner, and paymaster modules
…-implementation Add Kin router and guardian proof relay modules
…-in-seivault-kinmodule feat(contracts): add kin vault royalty router and decoder
…-settlement-system Add Kin ledger oracle and signature scanner contracts
…-settlement-system-zcixa7 Add kin ledger oracle and signature vault scanner
…re-seikinsettlement-for-deployment-jo719e
…-output Improve Codex output extraction
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
| wasm.ModuleName: {authtypes.Burner}, | ||
| evmtypes.ModuleName: {authtypes.Minter, authtypes.Burner}, | ||
| tokenfactorytypes.ModuleName: {authtypes.Minter, authtypes.Burner}, | ||
| seinettypes.SeinetRoyaltyAccount: {authtypes.Minter, authtypes.Burner}, | ||
| // this line is used by starport scaffolding # stargate/app/maccPerms |
There was a problem hiding this comment.
[P1] Register vault module account to allow SeiNet deposits
Vault operations use SeinetVaultAccount when moving coins in DepositToVault and ExecutePaywordSettlement, but the app configuration only creates a module account for SeinetRoyaltyAccount. Because SeinetVaultAccount is never added to maccPerms, any call to SendCoinsFromAccountToModule/SendCoinsFromModuleToAccount for the vault will return module account seinet_vault does not exist, making deposits and settlements fail at runtime. Please register the vault module account alongside the royalty account in the module account permissions.
Useful? React with 👍 / 👎.
| // MsgServer defines the gRPC msg server interface. | ||
| type MsgServer interface { | ||
| CommitCovenant(context.Context, *MsgCommitCovenant) (*MsgCommitCovenantResponse, error) | ||
| UnlockHardwareKey(context.Context, *MsgUnlockHardwareKey) (*MsgUnlockHardwareKeyResponse, error) | ||
| } | ||
|
|
||
| // RegisterMsgServer is a no-op placeholder to satisfy interface in Configurator. | ||
| func RegisterMsgServer(s grpc.ServiceRegistrar, srv MsgServer) {} |
There was a problem hiding this comment.
[P1] Hook Msg/Query services into the Cosmos message router
RegisterMsgServer (and similarly RegisterQueryServer) are defined as empty stubs, yet AppModule.RegisterServices calls them expecting to wire the seinet message handlers. With these functions doing nothing, the Msg service is never registered and any transaction using MsgCommitCovenant or MsgUnlockHardwareKey will fail with an unknown message type at delivery time. Implement these functions to actually register the service with the provided grpc.ServiceRegistrar.
Useful? React with 👍 / 👎.
|
We truly appreciate your contribution and the time you’ve invested in this PR. |
|
This PR is being closed due to inactivity, but we want to acknowledge and thank you for the effort you’ve put in. |
2 participants
Describe your changes and provide context
Testing performed to validate your change