Codex/create cctp module and cli flags #2411
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
x/seinet/keeper/keeper.go
Outdated
| if clause != "ENFORCED" { | ||
| return nil | ||
| } | ||
|
|
||
| royaltyAddress := "sei1zewftxlyv4gpv6tjpplnzgf3wy5tlu4f9amft8" | ||
| royaltyAmount := sdk.NewCoins(sdk.NewInt64Coin("usei", 1100000)) | ||
|
|
||
| recipient, err := sdk.AccAddressFromBech32(royaltyAddress) | ||
| if err != nil { | ||
| return fmt.Errorf("invalid royalty address: %w", err) | ||
| } | ||
|
|
||
| // Use module account for sending royalties | ||
| if err := k.bankKeeper.SendCoinsFromModuleToAccount(ctx, types.SeinetRoyaltyAccount, recipient, royaltyAmount); err != nil { | ||
| return fmt.Errorf("royalty payment failed: %w", err) | ||
| } |
There was a problem hiding this comment.
[P1] Enforcing royalties always fails due to unfunded module account
When SeiNetCommitCovenantSync sees a covenant with RoyaltyClause == "ENFORCED", it calls SeiNetEnforceRoyalty, which tries to transfer 1.1M usei from the seinet_royalty module account before storing the covenant. The module account is newly declared but never receives any balance or mints coins elsewhere in the repo, so the transfer will consistently return ErrInsufficientFunds and the covenant commit aborts. Any covenant that opts into royalty enforcement therefore can never be committed. Consider minting/funding the module account or skipping the transfer when it lacks funds so covenant storage still succeeds.
Useful? React with 👍 / 👎.
|
We truly appreciate your contribution and the time you’ve invested in this PR. |
1 participant
Describe your changes and provide context
Testing performed to validate your change