Flatten BeginBlock and remove nested logics #2522
Open
+382
−552
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codchen
force-pushed
the
tony/streamline-abci
branch
from
8a736a9 to
e3332ea
Compare
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (30.76%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #2522 +/- ##
==========================================
- Coverage 43.22% 43.17% -0.05%
==========================================
Files 1583 1586 +3
Lines 138846 138790 -56
==========================================
- Hits 60011 59925 -86
- Misses 73389 73425 +36
+ Partials 5446 5440 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
codchen
force-pushed
the
tony/streamline-abci
branch
2 times, most recently
from
b18902f to
5e3e8bf
Compare
codchen
force-pushed
the
tony/streamline-abci
branch
from
5e3e8bf to
6bc167c
Compare
udpatil
reviewed
Nov 3, 2025
udpatil
approved these changes
Nov 3, 2025
| func (am AppModule) BeginBlock(ctx sdk.Context, _ abci.RequestBeginBlock) { | ||
| defer telemetry.ModuleMeasureSince(types.ModuleName, time.Now(), telemetry.MetricKeyBeginBlocker) | ||
|
|
||
| am.keeper.InitMemStore(ctx) |
There was a problem hiding this comment.
why was this not previously calling capability's BeginBlocker function which also just calls the InitMemStore?
There was a problem hiding this comment.
i'm not quite sure - could just be a refactor oversight from cosmos-sdk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Previously, BeginBlock follows a very involved call path:
This PR simplifies BeginBlock to be
SeiApp->keepersTesting performed to validate your change
no functional change