Skip to content

Marked copy operations as deleted for uncopiable types. #2008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from
Draft

Marked copy operations as deleted for uncopiable types. #2008

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions Pcap++/header/KniDevice.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,10 +232,10 @@ namespace pcpp
private:
/// All instances of this class MUST be produced by KniDeviceList class
KniDevice(const KniDeviceConfiguration& conf, size_t mempoolSize, int unique);
/// This class is not copyable
KniDevice(const KniDevice&);
/// This class is not copyable
KniDevice& operator=(const KniDevice&);

KniDevice(const KniDevice&) = delete;
KniDevice& operator=(const KniDevice&) = delete;

/// All instances of this class MUST be destroyed by KniDeviceList class
~KniDevice();

Expand Down
8 changes: 4 additions & 4 deletions Pcap++/header/LinuxNicInformationSocket.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,10 @@ namespace pcpp
/// Tries to open handled socket on construction.
/// If fails prints the debug message
LinuxNicInformationSocket();

LinuxNicInformationSocket(const LinuxNicInformationSocket&) = delete;
LinuxNicInformationSocket operator=(const LinuxNicInformationSocket&) = delete;

/// Closes handled socket on destruction.
/// If no socket was opened prints the debug message
~LinuxNicInformationSocket();
Expand All @@ -50,10 +54,6 @@ namespace pcpp
bool makeRequest(const char* nicName, const IoctlType ioctlType, ifreq* request);

private:
/// Hidden copy constructor. This structure is not copyable
LinuxNicInformationSocket(const LinuxNicInformationSocket&);
/// Hidden copy assignment operator. This structure is not copyable
LinuxNicInformationSocket operator=(const LinuxNicInformationSocket&);
LinuxSocket m_Socket;
};
} // namespace pcpp
Loading