Check and inform if wallet output descriptor has change addr#561
Merged
odudex merged 5 commits intoselfcustody:developfrom May 6, 2025
Merged
Check and inform if wallet output descriptor has change addr#561odudex merged 5 commits intoselfcustody:developfrom
odudex merged 5 commits intoselfcustody:developfrom
Conversation
Member
|
Neat! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #561 +/- ##
===========================================
+ Coverage 95.42% 95.43% +0.01%
===========================================
Files 76 76
Lines 8696 8703 +7
===========================================
+ Hits 8298 8306 +8
+ Misses 398 397 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
50d608f to
c7f5a5a
Compare
qlrd
suggested changes
Apr 11, 2025
qlrd
suggested changes
Apr 11, 2025
c7f5a5a to
418609f
Compare
Member
|
diybitcoinhardware/embit#76 has been merged into Embit's develop branch. |
Member
Author
|
As I had to fix a conflict, I've also removed |
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
@qlrd noticed while improving tests that an wallet output descriptor without info on change derivation index would show the same addresses as receive index.
Note: this PR is assuming that embit is correct for miniscript, so this embit PR needs to be merged beforehand - diybitcoinhardware/embit#74
Changes made to:
What is the purpose of this pull request?