Skip to content

Check and inform if wallet output descriptor has change addr#561

Merged
odudex merged 5 commits intoselfcustody:developfrom
tadeubas:wallet-desc-addr
May 6, 2025
Merged

Check and inform if wallet output descriptor has change addr#561
odudex merged 5 commits intoselfcustody:developfrom
tadeubas:wallet-desc-addr

Conversation

@tadeubas
Copy link
Member

@tadeubas tadeubas commented Apr 9, 2025

What is this PR for?

@qlrd noticed while improving tests that an wallet output descriptor without info on change derivation index would show the same addresses as receive index.

  • Wallet Descriptor now validates and warns if it was unable to determine change addresses.
  • Hide change address menu option when index not available.

Note: this PR is assuming that embit is correct for miniscript, so this embit PR needs to be merged beforehand - diybitcoinhardware/embit#74

Changes made to:

  • Code
  • Tests
  • Docs
  • CHANGELOG

What is the purpose of this pull request?

  • Bug fix
  • New feature
  • Docs update
  • Other

@odudex
Copy link
Member

odudex commented Apr 9, 2025

Neat!

@tadeubas tadeubas marked this pull request as ready for review April 11, 2025 08:32
@codecov
Copy link

codecov bot commented Apr 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.43%. Comparing base (5362607) to head (66f2c3d).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #561      +/-   ##
===========================================
+ Coverage    95.42%   95.43%   +0.01%     
===========================================
  Files           76       76              
  Lines         8696     8703       +7     
===========================================
+ Hits          8298     8306       +8     
+ Misses         398      397       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@odudex
Copy link
Member

odudex commented May 6, 2025

diybitcoinhardware/embit#76 has been merged into Embit's develop branch.
Can you fix conflicts on Krux's PR so it can be merged?

@tadeubas
Copy link
Member Author

tadeubas commented May 6, 2025

As I had to fix a conflict, I've also removed \r\n from tests

@tadeubas tadeubas requested a review from qlrd May 6, 2025 14:02
@odudex odudex merged commit 28b6ddc into selfcustody:develop May 6, 2025
7 checks passed
@odudex
Copy link
Member

odudex commented May 6, 2025

Thank you!

@tadeubas tadeubas deleted the wallet-desc-addr branch December 11, 2025 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants