Skip to content

refactor: reduce overhead in foundation-ur and urtypes integration#825

Open
tadeubas wants to merge 1 commit intoselfcustody:developfrom
tadeubas:ur-libs-usage
Open

refactor: reduce overhead in foundation-ur and urtypes integration#825
tadeubas wants to merge 1 commit intoselfcustody:developfrom
tadeubas:ur-libs-usage

Conversation

@tadeubas
Copy link
Member

@tadeubas tadeubas commented Feb 3, 2026

What is this PR for?

  • Refactored imports to target only the required modules
  • Removed duplicated UR object creation in qr.py
  • Fixed test logic in test_qr.py (no change in test outcomes)

Changes made to:

  • Code
  • Tests
  • Docs
  • CHANGELOG

Did you build the code and tested on device?

  • Yes, build and tested on

What is the purpose of this pull request?

  • Bug fix
  • New feature
  • Docs update
  • Other

@codecov
Copy link

codecov bot commented Feb 3, 2026

Codecov Report

❌ Patch coverage is 96.42857% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 97.31%. Comparing base (5ae4ff5) to head (eab0c94).

Files with missing lines Patch % Lines
src/krux/pages/datum_tool.py 94.73% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #825   +/-   ##
========================================
  Coverage    97.31%   97.31%           
========================================
  Files           83       83           
  Lines        10568    10573    +5     
========================================
+ Hits         10284    10289    +5     
  Misses         284      284           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant