Serialization and HTML subdirectories when bundling#1356
Serialization and HTML subdirectories when bundling#1356coltonglasgow wants to merge 7 commits intodevelopfrom
Conversation
stevenchalem
left a comment
There was a problem hiding this comment.
This runs fine under Windows 11. Also see my comment at #1347 (comment)
|
I have updated this PR based on the feedback from the issue: #1347. |
| excludes: | ||
| - gistValidationAnnotations.ttl |
There was a problem hiding this comment.
This is a duplicate line that did not do anything. This file is being excluded above on line 107.
stevenchalem
left a comment
There was a problem hiding this comment.
Runs correctly under Windows 11 and produces the correct results.
|
Directory names |
@rjyounes I have applied this suggestion in the latest commit. |
rjyounes
left a comment
There was a problem hiding this comment.
Looks good, everything works. I have just a suggestion for the release note.
Co-authored-by: Rebecca Younes <rebecca.younes@semanticarts.com>
rjyounes
left a comment
There was a problem hiding this comment.
Sorry, one more round on the release note.
| @@ -0,0 +1,3 @@ | |||
| ### Patch Updates | |||
|
|
|||
| - Added format-specific directory creation for ontology and documentation files to `bundle.yaml`. Issue [#1347](https://github.com/semanticarts/gist/issues/1347). | |||
There was a problem hiding this comment.
I think I suggested a change to this once already, but now it strikes me it would be better to word the note in terms of what the user will see in the release package rather than what the code change was. E.g., something like "Modified build to store ontology and documentation files in format-specific directories in the release package."
sa-bpelakh
left a comment
There was a problem hiding this comment.
Looks good, I didn't even remember that onto-tool automatically created output directories. 😄
Closes #1347
I have implemented the following when bundling:
turtle,rdf-xml, andjson-lddirectories in theontologiesdirectory.markdownandhtmldirectories fordocs/andmigration/v*/.docs/markdown/models/anddocs/html/models/.This gist bundle contains the changes listed above: gist14.1.0_webDownload.zip
This screenshot is from the gist bundle (above) showing the changes:
