Skip to content

Delete/Deprecate gist:Building#1403

Merged
rjyounes merged 3 commits intodevelopfrom
brett-heffelfinger/1205-delete-gistbuilding
Mar 5, 2026
Merged

Delete/Deprecate gist:Building#1403
rjyounes merged 3 commits intodevelopfrom
brett-heffelfinger/1205-delete-gistbuilding

Conversation

@brett-heffelfinger
Copy link
Contributor

Major Updates

  • Deprecated classes gist:Landmark and gist:Building. Issue #1205.

Minor Updates

  • Changed examples of gist:PhysicalIdentifiableItem to include a landmark and building. Issue #1205.
  • Modified existing examples of gist:PhysicalIdentifiableItem to be more specific. Issue #1205.

;
skos:definition "A discrete physical object which, if subdivided, will result in parts that are distinguishable in nature from the whole and in general also from the other parts."^^xsd:string ;
skos:example "A computer, a book, a car."^^xsd:string ;
skos:example "A laptop, a physical book, a car, a building, a landmark (such as a tree stump with an etched marking to denote a campsite)."^^xsd:string ;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't love the repeated indefinite articles (I know they didn't originate with you). What do you think of just "A computer, physical book, car..."?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's something odd about it to me. I'm not quite sure what, but here they are side-by-side:

A laptop, a physical book, a car, a building, a landmark (such as a tree stump with an etched marking to denote a campsite).

A laptop, physical book, car, building, landmark (such as a tree stump with an etched marking to denote a campsite).

Maybe it's that the second makes me think there should explicitly be an "or" before landmark, and adding that implies the examples are a finite set. The example of the example (in parentheses) is also throwing me for a loop, but I thought something like that was necessary to indicate what a landmark could be.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I'm OK with it as is. There's something odd about it to me either way.

Co-authored-by: Rebecca Younes <rebecca.younes@semanticarts.com>
@rjyounes rjyounes self-requested a review March 5, 2026 19:15
@rjyounes rjyounes merged commit c22534a into develop Mar 5, 2026
1 check passed
@rjyounes rjyounes deleted the brett-heffelfinger/1205-delete-gistbuilding branch March 5, 2026 19:15
@github-project-automation github-project-automation bot moved this from In Review to Done in gist Version 14.1.0 Mar 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

Delete gist:Building

3 participants