feat: Group symbol analysis by subproject #389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmcqd
changed the title
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
mmcqd
force-pushed
the
06-27-group_symbol_analysis_by_subproject
branch
from
1d60132 to
67f927f
Compare
|
Backwards compatibility summary: |
mmcqd
force-pushed
the
06-27-group_symbol_analysis_by_subproject
branch
2 times, most recently
from
4860d5e to
cf7677d
Compare
3 tasks
Sly1029
approved these changes
Jul 8, 2025
Sly1029
reviewed
Jul 8, 2025
| (* since semgrep 1.108.0 *) | ||
| ?symbol_analysis: symbol_analysis option; | ||
| (* since semgrep 1.128.0 *) | ||
| ?ungrouped_symbol_analysis: ungrouped_symbol_analysis option; |
Contributor
There was a problem hiding this comment.
What is this ungrouped_symbol_analysis?
mmcqd
force-pushed
the
06-27-group_symbol_analysis_by_subproject
branch
from
cf7677d to
72b69ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need this data to be grouped by dependency subproject, so it works for monorepos. This change is backwards incompatible, but we're going to disable this for all older versions of semgrep.
make setup && maketo update the generated code after editing a.atdfile (TODO: have a CI check)For example, the Semgrep backend need to still be able to consume data
generated by Semgrep 1.50.0.
See https://atd.readthedocs.io/en/latest/atdgen-tutorial.html#smooth-protocol-upgrades
Note that the types related to the semgrep-core JSON output or the
semgrep-core RPC do not need to be backward compatible!
semgrep-proprietaryare approved and ready to merge once this PR is merged