chore(dep-resolution): add option to specify dependency configurations to include #421
+77
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkettle
force-pushed
the
bk/dependency-configuration
branch
from
8f7915d to
7107cd5
Compare
|
Backwards compatibility summary: |
mjambon
approved these changes
Nov 20, 2025
Member
mjambon
left a comment
mjambon
left a comment
There was a problem hiding this comment.
Note that you'll get merge conflicts since the comments are now <doc text="..."> annotations.
| allow_local_builds: bool; | ||
| (* the configurations (e.g. gradle configurations) to resolve. If not specified, | ||
| * all configurations will be resolved. Supported only for Gradle currently. *) | ||
| include_dependency_configurations: string list option; |
Member
There was a problem hiding this comment.
It should be:
?include_dependency_configurations: string list option;
because it makes the field optional (otherwise it's a weird JSON representation and probably a weird python representation too)
Member
There was a problem hiding this comment.
Hmm, ok, the Python interface isn't bad. It's just the JSON representation for the option type that's unidiomatic if you don't pair option with a question mark on the field name.
Member
There was a problem hiding this comment.
Note that if you want to default to the empty list rather than a None, it is achieved with
~include_dependency_configurations: string list;
Contributor
Author
There was a problem hiding this comment.
Hmm, doing so will make the Python argument optional, right? I wanted to have the argument be required but nullable. But it's not important, I can change it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new parameter to the ResolveDependencies RPC that allows specifying a
list of configurations to include in the resolution. We could alternately do
this by RPC, but it seemed worth it to do it as a CLI flag so we can potentially
use it in the future.
make setup && maketo update the generated code after editing a.atdfile (TODO: have a CI check)For example, the Semgrep backend need to still be able to consume data
generated by Semgrep 1.50.0.
See https://atd.readthedocs.io/en/latest/atdgen-tutorial.html#smooth-protocol-upgrades
Note that the types related to the semgrep-core JSON output or the
semgrep-core RPC do not need to be backward compatible!
semgrep-proprietaryare approved and ready to merge once this PR is merged