Set the modification time of the packaged assets to equal the constituents.#1
Open
bouchard wants to merge 4 commits intosentientmonkey:masterfrom
Open
Conversation
…ing asset_packager to use module and stop shuffling files / invoking ruby
…ently updated source file. This allows Rails asset IDs to work as intended - if the source files haven't been modified when a new build is done (typically at deploy time), the asset IDs will stay the same so browsers don't need to re-download.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rails uses the modification time of the CSS/JS packaged file in the URL as a cache-busting mechanism. To prevent users from having to re-download a packaged asset after a deploy or re-gen of the packaged files, the packaged assets should take their mod time from the latest modded file that is part of the package.
I know this commit has messy newline's attached to it, let me know if you want me to redo it before you commit. I appreciate any comments you might have!