Conversation
senwu
added
enhancement
Codecov Report
@@ Coverage Diff @@
## master #104 +/- ##
==========================================
+ Coverage 85.24% 85.34% +0.10%
==========================================
Files 40 40
Lines 1958 1959 +1
Branches 418 417 -1
==========================================
+ Hits 1669 1672 +3
+ Misses 173 172 -1
+ Partials 116 115 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
lorr1
approved these changes
Oct 27, 2021
Collaborator
lorr1
left a comment
lorr1
left a comment
There was a problem hiding this comment.
Looks good. If you're really ambitious, you might be able to make an issue on rich's github to see if they have any suggestions for how to get rich in the trainer you have.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problems or issues
Rich has a really nice visualization for logging and many advanced features. We want to use rich for logging and training process monitoring.
Description of the proposed changes
Switch tqdm to rich.
Test plan
Pass all existing tests.
Checklist