Skip to content

update for SzDatabaseConnectionLostError#119

Merged
kernelsam merged 1 commit intomainfrom
skern-errors-1
Apr 13, 2026
Merged

update for SzDatabaseConnectionLostError#119
kernelsam merged 1 commit intomainfrom
skern-errors-1

Conversation

@kernelsam
Copy link
Copy Markdown
Contributor

Pull request questions

Which issue does this address

Issue number: #nnn

Why was change needed

???

What does change improve

???

@kernelsam kernelsam requested a review from a team as a code owner April 13, 2026 21:22
@kernelsam kernelsam enabled auto-merge (squash) April 13, 2026 21:22
@kernelsam kernelsam merged commit 65fd449 into main Apr 13, 2026
19 checks passed
@kernelsam kernelsam deleted the skern-errors-1 branch April 13, 2026 21:23
@github-actions
Copy link
Copy Markdown

🤖 Claude Code Review


PR Code Review

Summary

This PR reclassifies error code 1020 (EAS_ERR_DATABASE_CONNECTION_NEEDS_VALIDATION) from the generic base SzError to the more specific SzDatabaseConnectionLostError across all 5 language targets (Python, Go, Java, C#, Rust). The Rust file also picks up error 9807 which was already in szerrors.json and other generated files but missing from errortypes.rs due to it being last regenerated on 2026-02-02.


Code Quality

✅ Style guide — Changes follow existing conventions consistently across all language targets.

✅ No commented-out code — None introduced.

✅ Meaningful names — No new identifiers introduced.

✅ DRY principle — The single szerrors.json source of truth is updated and all generated files are regenerated consistently.

✅ Defects/Logic errors — The reclassification is semantically correct: "Database Connection Needs Validation" is a retryable condition, so mapping it to SzDatabaseConnectionLostError (which inherits from SzRetryableError) is appropriate. The Go hierarchy {SzDatabaseConnectionLostError, SzRetryableError, SzError} is consistent with other retryable errors in the file.

✅ 9807 in Rust — Confirmed that 9807 already exists in szerrors.json and all other generated files (Go:470, Python:614, Java:489, C#:486). The Rust file was simply stale (last generated 2026-02-02) and this regeneration catches it up. No inconsistency.

✅ CLAUDE.md — Project instructions are appropriate for shared developer use.


Testing

❌ No test files present — There are no tests in this repository at all (no tests/ directory). Given this is a code-generation tool, consider whether tests should exist for:

  • The generators themselves (e.g., assert error 1020 maps to SzDatabaseConnectionLostError in the output)
  • Validation that all generated files are in sync with szerrors.json

This is a pre-existing gap rather than a regression introduced by this PR.


Documentation

❌ CHANGELOG.md not updated — The [Unreleased] section in CHANGELOG.md only mentions the Rust generator addition. This PR changes the behavior of error 1020 across all SDKs (a semantic change for consumers), which warrants a ### Changed in Unreleased entry such as:

### Changed in Unreleased

- Changed error 1020 (`EAS_ERR_DATABASE_CONNECTION_NEEDS_VALIDATION`) from `SzError` to `SzDatabaseConnectionLostError`

✅ Inline comments — Auto-generated comment annotations are preserved and accurate.

✅ README — No README changes needed; architecture and workflow are unchanged.


Security

✅ No hardcoded credentials
✅ No sensitive data in logs
✅ No license files
✅ Input validation — N/A for generated mapping tables.


Summary Table

Category Status Item
Semantic correctness of 1020 reclassification
Consistency across all language targets
9807 in Rust (catch-up, not a new entry)
CHANGELOG.md updated Add entry for 1020 reclassification
Tests Pre-existing gap; no tests exist in repo

The core change is correct and well-executed. The only actionable item for this PR is updating CHANGELOG.md.

Automated code review analyzing defects and coding standards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants