-
Notifications
You must be signed in to change notification settings - Fork 6
Updated Serilog and Glimpse dependencies to latest v2 (betas) #6
base: dev
Are you sure you want to change the base?
Conversation
|
A few issues, In beta-1, glimpse uses "glimpse.core" for .net 4.5, but for .net 4.6 - glimpse now has a "glimpse.common" assembly. I am going to expand this PR so that we can have 1 project that builds a NuGet package, with support for .net 4.5 (which it currently has) and also .net 4.6 (which I need) The easiest way to achieve this for me would be to change this project to make it a dnx based library project (requires vs 2015?) The new beta-1 nuget packages for serilog and glimpse also require a minimum NuGet version of "3" in order to download them - and VS 2013 only supports NuGet client upto 2.8 currently. So I am going to upgrade the solution to VS 2015, convert the project to a Dnx based library project, and add support for .net 4.6, whilst keeping the existing .net 4.5 support. |
… that builds against .net 4.5 and .net 4.6. When you build the project, the NuGet package is produced in the src/artifacts directory - and now includes libs for both .net 4.5 and .net 4.6.
|
The project has been converted now and produces a NuGet package on build that supports .net 4.5 and .net 4.6. The only issue is that I am not too familiar with AppVeyor, and I have not adjusted the build.ps1 file accordingly. The build.ps1 file needs to be amended to build the new "xproj" project, with the appropriate flag to output the nuget package in the correct place and all that good stuff. |
|
I have published a NuGet package from this PR so I can test it out in my project: https://www.nuget.org/packages/Serilog.Sinks.Glimpse-DazinatorFork/2.0.0-beta2 |
|
Excellent, thanks very much for that. I've enabled the issue tracker on this repo (just recently had a "policy switch" - we previously centralised issues in serilog/serilog). I'll create a dev branch so that we can merge this while master stays on the RTM bits for now. |
|
Cool, no rush.. I'm still working on this in the meantime, as there do look to be more issues to overcome. |
|
Hey @dazinator - just following up on this thanks to a prompt from @rlenders in #7. Are you keen to update this to the current tooling/project.json, or should we close this one and get a fresh PR up for 2.0 support? Thanks! |
|
I'll have a quick look tomorrow and let you know. |
I am using the latest beta's of glimpse and serilog, I came accross this sink, and thought perhaps it could be updated.
You don't have issues enabled on GitHub, otherwise I would have raised one!
Also, you probably don't want this merged into "master" - so happy to retarget this PR if you would prefer to create a seperate branch for this - or reject it entirely!