Skip to content

Conversation

@jdm
Copy link
Member

@jdm jdm commented Nov 4, 2025

Our deploys are busted again.

@jdm jdm requested review from delan and mrobinson as code owners November 4, 2025 23:00
@delan
Copy link
Member

delan commented Nov 5, 2025

hmm, this looks like an unstable release, even though it’s marked as latest, and there are breaking changes. i wonder if we should make the workflow consider only stable releases instead, and wait until 0.5.0 is out before migrating?

@delan
Copy link
Member

delan commented Nov 5, 2025

something like this: f4f24f6

@jdm
Copy link
Member Author

jdm commented Nov 5, 2025

I have to say I really dislike the current system that insists we always have to use the latest version available.

@jdm
Copy link
Member Author

jdm commented Nov 5, 2025

something like this: f4f24f6

I'd be fine with this to get deploys unblocked.

@delan
Copy link
Member

delan commented Nov 5, 2025

I have to say I really dislike the current system that insists we always have to use the latest version available.

tbh i think i would also prefer just pinning some specific version, and updating whenever we feel like it: 801d0bd

@delan
Copy link
Member

delan commented Nov 5, 2025

i’ve opened #156 :)

Copy link
Member

@mrobinson mrobinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've gone ahead and finished the upgrade here as mdbook 0.5 is stable now. @jdm, if this looks good to you, feel free to land it.

@mrobinson mrobinson changed the title use mdbook 0.5 Use mdbook@0.5.1 and mdbook-mermaid@0.17.0 Dec 6, 2025
@jdm jdm added this pull request to the merge queue Dec 6, 2025
Merged via the queue into main with commit 1041efa Dec 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants