Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions bun.lock
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"@graphprotocol/graph-cli": "0.96.0",
"@graphprotocol/graph-ts": "0.38.0",
"@nomicfoundation/hardhat-foundry": "1.2.0",
"@nomicfoundation/hardhat-ignition-viem": "0.15.15",
"@nomicfoundation/hardhat-ignition-viem": "0.15.16",
"@nomicfoundation/hardhat-toolbox-viem": "4.1.1",
"@nomiclabs/hardhat-solhint": "4.1.0",
"@openzeppelin/contracts": "5.4.0",
Expand Down Expand Up @@ -196,7 +196,7 @@

"@nomicfoundation/hardhat-ignition": ["@nomicfoundation/hardhat-ignition@0.15.15", "", { "dependencies": { "@nomicfoundation/ignition-core": "^0.15.14", "@nomicfoundation/ignition-ui": "^0.15.13", "chalk": "^4.0.0", "debug": "^4.3.2", "fs-extra": "^10.0.0", "json5": "^2.2.3", "prompts": "^2.4.2" }, "peerDependencies": { "@nomicfoundation/hardhat-verify": "^2.1.0", "hardhat": "^2.26.0" } }, "sha512-4uLp5MOyaW0gUYGAxiA8GikGIo8SLBijpxakFI3BpofUoeRXnnQdNtRJT9aAKD8ENfvFQrNFin0Z1VlXjXurkA=="],

"@nomicfoundation/hardhat-ignition-viem": ["@nomicfoundation/hardhat-ignition-viem@0.15.15", "", { "peerDependencies": { "@nomicfoundation/hardhat-ignition": "^0.15.15", "@nomicfoundation/hardhat-viem": "^2.1.0", "@nomicfoundation/ignition-core": "^0.15.14", "hardhat": "^2.26.0", "viem": "^2.7.6" } }, "sha512-YUL1avW+TEh+nQEzoKwp8SpK9O7gW/Q3vJs95Xhtmz6RJQynWrjSOXVK43xNfzpbS/C+kfPa+A6DF1Sr19H6kg=="],
"@nomicfoundation/hardhat-ignition-viem": ["@nomicfoundation/hardhat-ignition-viem@0.15.16", "", { "peerDependencies": { "@nomicfoundation/hardhat-ignition": "^0.15.16", "@nomicfoundation/hardhat-viem": "^2.1.0", "@nomicfoundation/ignition-core": "^0.15.15", "hardhat": "^2.26.0", "viem": "^2.7.6" } }, "sha512-BKWRZSkW1dLMW6VRjQCLei+JGYmotTsQo/QeR21CyVG0FMkPESTU6X1XPKynqNjaYJebV8rDsjtdB/Bzi7FRog=="],

"@nomicfoundation/hardhat-network-helpers": ["@nomicfoundation/hardhat-network-helpers@1.1.2", "", { "dependencies": { "ethereumjs-util": "^7.1.4" }, "peerDependencies": { "hardhat": "^2.26.0" } }, "sha512-p7HaUVDbLj7ikFivQVNhnfMHUBgiHYMwQWvGn9AriieuopGOELIrwj2KjyM2a6z70zai5YKO264Vwz+3UFJZPQ=="],

Comment on lines 196 to 202
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The bun.lock file is out of sync with package.json peer dependencies for @nomicfoundation/hardhat-ignition and @nomicfoundation/ignition-core.
Severity: MEDIUM | Confidence: High

🔍 Detailed Analysis

The package.json was updated to @nomicfoundation/hardhat-ignition version 0.15.16, which introduces new peer dependency requirements for @nomicfoundation/hardhat-ignition (^0.15.16) and @nomicfoundation/ignition-core (^0.15.15). However, the bun.lock file was not regenerated and still reflects older installed versions (@nomicfoundation/hardhat-ignition@0.15.15 and @nomicfoundation/ignition-core@0.15.14). This peer dependency mismatch will cause issues when developers run bun install if strict peer dependency constraints are enforced, potentially leading to build failures or unexpected runtime behavior.

💡 Suggested Fix

Regenerate the bun.lock file by running bun install or bun update after updating package.json to ensure all peer dependencies are correctly resolved and reflected.

🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: bun.lock#L196-L202

Potential issue: The `package.json` was updated to `@nomicfoundation/hardhat-ignition`
version `0.15.16`, which introduces new peer dependency requirements for
`@nomicfoundation/hardhat-ignition` (`^0.15.16`) and `@nomicfoundation/ignition-core`
(`^0.15.15`). However, the `bun.lock` file was not regenerated and still reflects older
installed versions (`@nomicfoundation/hardhat-ignition@0.15.15` and
`@nomicfoundation/ignition-core@0.15.14`). This peer dependency mismatch will cause
issues when developers run `bun install` if strict peer dependency constraints are
enforced, potentially leading to build failures or unexpected runtime behavior.

Did we get this right? 👍 / 👎 to inform future reviews.
Reference ID: 5330720

Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
"@graphprotocol/graph-cli": "0.96.0",
"@graphprotocol/graph-ts": "0.38.0",
"@nomicfoundation/hardhat-foundry": "1.2.0",
"@nomicfoundation/hardhat-ignition-viem": "0.15.15",
"@nomicfoundation/hardhat-ignition-viem": "0.15.16",
"@nomicfoundation/hardhat-toolbox-viem": "4.1.1",
"@nomiclabs/hardhat-solhint": "4.1.0",
"@openzeppelin/contracts": "5.4.0",
Expand Down
Loading