-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
fix: missing closing animations in select and menubar components #8545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@naaa760 is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
|
Looks like this PR modifies files in Consider applying the change to |
|
thanks! also provide a video demo, make sure it's mp4 for github preview to work, you can use handbrake for mp4 conversion and a small file size |
|
Looks like this PR modifies files in Consider applying the change to |
|
@clicktodev |
|
Looks like this PR modifies files in Consider applying the change to |
fixes: #8526
solution: Added the missing data-[state=closed]:animate-out CSS class to MenubarContent components in both www registry variants to match the animation pattern used by Popover and other dropdown components.
Files Changed:
apps/www/registry/new-york/ui/menubar.tsx
apps/www/registry/default/ui/menubar.tsx
apps/v4/registry/new-york-v4/ui/menubar.tsx
result: All dropdown-style components now have consistent closing animations with smooth fade-out and zoom effects when dismissed.