Skip to content

Conversation

@naaa760
Copy link
Contributor

@naaa760 naaa760 commented Oct 23, 2025

fixes: #8526

  • solution: Added the missing data-[state=closed]:animate-out CSS class to MenubarContent components in both www registry variants to match the animation pattern used by Popover and other dropdown components.

  • Files Changed:
    apps/www/registry/new-york/ui/menubar.tsx
    apps/www/registry/default/ui/menubar.tsx
    apps/v4/registry/new-york-v4/ui/menubar.tsx

  • result: All dropdown-style components now have consistent closing animations with smooth fade-out and zoom effects when dismissed.

@vercel
Copy link
Contributor

vercel bot commented Oct 23, 2025

@naaa760 is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Contributor

Looks like this PR modifies files in apps/www, which is deprecated.

Consider applying the change to apps/v4 if relevant.

@clicktodev
Copy link
Contributor

clicktodev commented Oct 23, 2025

thanks!
apply the changes only to v4 for now, also the animation is still missing for the select component

also provide a video demo, make sure it's mp4 for github preview to work, you can use handbrake for mp4 conversion and a small file size

@github-actions
Copy link
Contributor

Looks like this PR modifies files in apps/www, which is deprecated.

Consider applying the change to apps/v4 if relevant.

@naaa760
Copy link
Contributor Author

naaa760 commented Oct 25, 2025

@clicktodev
fixed it let me know!

@github-actions
Copy link
Contributor

Looks like this PR modifies files in apps/www, which is deprecated.

Consider applying the change to apps/v4 if relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[feat]: Select and Menubar closing animation

2 participants