fix: resolve react-hooks/purity ESLint error in sidebarmenuskeleton #8546
+9
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description for #8540
Fix react-hooks/purity ESLint error in SidebarMenuSkeleton component
Problem: The
react-hooks/purityESLint rule was flagging an error becauseMath.random()was being called inside auseMemohook during render, which violates React's purity requirements.Solution: Converted
useMemotouseStatewith lazy initialization to ensure the random width calculation only happens once during component initialization, not on every render.Changes made:
SidebarMenuSkeletoncomponent in all three variants (v4, www/default, www/new-york)useMemo(() => Math.random()...)withuseState(() => Math.random()...)