Fix OptiX 8.1 compatibility for optixMakeHitObject wrappers. Fix #8723 #8730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The four optixMakeHitObject wrapper functions were enabled for OptiX 8.1+ but used OptixTraverseData and optixHitObjectGetTraverseData, which only exist in OptiX 9.0+. Added OptiX 8.1-specific implementations that call the native OptiX 8.1 APIs (optixMakeHitObject and optixMakeHitObjectWithRecord) with explicit SBT parameters.
Collaborator
|
What's the testing plan? |
Collaborator
Author
@jkiviluoto-nv would work on adding it to CI for have coverage for supported optix |
jvepsalainen-nv
pushed a commit
to jvepsalainen-nv/slang
that referenced
this pull request
Nov 4, 2025
…er-slang#8723 (shader-slang#8730) The four optixMakeHitObject wrapper functions were enabled for OptiX 8.1+ but used OptixTraverseData and optixHitObjectGetTraverseData, which only exist in OptiX 9.0+. Added OptiX 8.1-specific implementations that call the native OptiX 8.1 APIs (optixMakeHitObject and optixMakeHitObjectWithRecord) with explicit SBT parameters.
juliusikkala
pushed a commit
to juliusikkala/slang
that referenced
this pull request
Nov 12, 2025
…er-slang#8723 (shader-slang#8730) The four optixMakeHitObject wrapper functions were enabled for OptiX 8.1+ but used OptixTraverseData and optixHitObjectGetTraverseData, which only exist in OptiX 9.0+. Added OptiX 8.1-specific implementations that call the native OptiX 8.1 APIs (optixMakeHitObject and optixMakeHitObjectWithRecord) with explicit SBT parameters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The four optixMakeHitObject wrapper functions were enabled for OptiX 8.1+ but used OptixTraverseData and optixHitObjectGetTraverseData, which only exist in OptiX 9.0+. Added OptiX 8.1-specific implementations that call the native OptiX 8.1 APIs (optixMakeHitObject and optixMakeHitObjectWithRecord) with explicit SBT parameters.