Add descriptor handle support to render test framework #8814
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkiviluoto-nv
force-pushed
the
feature/descriptor-handle-support
branch
2 times, most recently
from
2e9499e to
19290ee
Compare
Fixes shader-slang#8631 Implements automatic detection and binding of descriptor handle types (.Handle) in the slang-test framework, enabling execution tests for bindless descriptor features. Detection Strategy: Descriptor handles are lowered to uint2 (SPIRV/DX12) stored in uniform data. The detector specifically matches this pattern and excludes uint64 (device addresses) and Resource types (Metal/CUDA pointers) to avoid false positives. If getDescriptorHandle() fails, falls back to regular binding. Changes: - Add isDescriptorHandleType() detecting uint2 in UNIFORM category - Modify assignBuffer/Texture/Sampler to allocate and bind descriptor handles - Determine access mode via getResourceAccess() reflection - Fix resource lifetime by adding all resources to TestResourceContext - Add test cases requiring -render-feature bindless and -emit-spirv-directly This fixes Vulkan validation errors (VUID-vkDestroyBuffer-buffer-00922) where buffers were destroyed while still in use by command buffers when using bindless descriptors
jkiviluoto-nv
force-pushed
the
feature/descriptor-handle-support
branch
from
19290ee to
b5d8cde
Compare
kaizhangNV
reviewed
Oct 28, 2025
| // Descriptor handles in SPIRV/DX12 with bindless are lowered to uint2 | ||
| // stored in uniform data. | ||
| // | ||
| // IMPORTANT: We only check for uint2, NOT uint64! |
Contributor
There was a problem hiding this comment.
Why don't we check uint64?
It's used when spvBindlessTextureNV is enabled. Though we might not have executable test for sampler or storage image.
Contributor
Author
There was a problem hiding this comment.
There was a mixup with device addresses which are also uint64. I'll add additional check for spvBindlessTextureNV.
csyonghe
reviewed
Oct 28, 2025
jvepsalainen-nv
pushed a commit
to jvepsalainen-nv/slang
that referenced
this pull request
Nov 4, 2025
…8814) Fixes shader-slang#8631 Implements automatic detection and binding of descriptor handle types (.Handle) in the slang-test framework, enabling execution tests for bindless descriptor features. Changes: - Add isDescriptorHandleType() to detect .Handle types via reflection - Modify assignBuffer/Texture/Sampler to allocate and bind descriptor handles - Fix resource lifetime by adding all resources to TestResourceContext - Add test case for descriptor handle with TEST_INPUT directives This fixes Vulkan validation errors (VUID-vkDestroyBuffer-buffer-00922) where buffers were destroyed while still in use by command buffers when using bindless descriptors. The implementation uses getDescriptorHandle() on resources and setDescriptorHandle() on shader cursors to properly bind handles for Vulkan and D3D12 backends.
juliusikkala
pushed a commit
to juliusikkala/slang
that referenced
this pull request
Nov 12, 2025
…8814) Fixes shader-slang#8631 Implements automatic detection and binding of descriptor handle types (.Handle) in the slang-test framework, enabling execution tests for bindless descriptor features. Changes: - Add isDescriptorHandleType() to detect .Handle types via reflection - Modify assignBuffer/Texture/Sampler to allocate and bind descriptor handles - Fix resource lifetime by adding all resources to TestResourceContext - Add test case for descriptor handle with TEST_INPUT directives This fixes Vulkan validation errors (VUID-vkDestroyBuffer-buffer-00922) where buffers were destroyed while still in use by command buffers when using bindless descriptors. The implementation uses getDescriptorHandle() on resources and setDescriptorHandle() on shader cursors to properly bind handles for Vulkan and D3D12 backends.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8631
Implements automatic detection and binding of descriptor handle types (.Handle) in the slang-test framework, enabling execution tests for bindless descriptor features.
Changes:
This fixes Vulkan validation errors (VUID-vkDestroyBuffer-buffer-00922) where buffers were destroyed while still in use by command buffers when using bindless descriptors.
The implementation uses getDescriptorHandle() on resources and setDescriptorHandle() on shader cursors to properly bind handles for Vulkan and D3D12 backends.