Skip to content

correct log endpoint #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

correct log endpoint #173

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/external/Collector.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -470,7 +470,7 @@ class Collector extends BaseExternal {
}

buildLogAPIUrl(request: any, baseDomain = CONFIG.explorerUrl): string {
const apiUrl = `${baseDomain}/api/v2/logs`
const apiUrl = `${baseDomain}/api/log`
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: Ensure that the new endpoint /api/log matches the expected API route on the backend. If the backend expects /api/logs or a different path, this change could break logging functionality. [possible issue, importance: 7]

Suggested change
const apiUrl = `${baseDomain}/api/log`
const apiUrl = `${baseDomain}/api/logs`

const queryParams: string[] = []

// Check if each query parameter exists in the request object and add it to the queryParams array if it does
Expand Down
Loading