Updates for sample-python #1
Conversation
| push: | ||
| branches: | ||
| - main | ||
| paths: |
There was a problem hiding this comment.
This section is used to make the action trigger only on changes to certain files. It's not required. In my example repo, I did it mainly to keep it from deploying on changes to the README. You can remove it completely like this or update it to include the things required for the python app (e.g. server.py).
| - name: Checkout master | ||
| uses: actions/checkout@main | ||
|
|
||
| - name: Update SHA |
There was a problem hiding this comment.
This is failing as it the directory does not exist. It is part of the static site example and not needed for the python app.
https://github.com/sharmita3/sample-python/runs/1481140544?check_suite_focus=true#step:3:4
| kind: Service | ||
| metadata: | ||
| name: python-example-service | ||
| annotations: |
There was a problem hiding this comment.
These annotations are used to manage DNS using external-dns and set up SSL. It's not strictly required for a push to deploy example and would require additional prerequisites.
https://www.digitalocean.com/docs/kubernetes/how-to/configure-load-balancers/#ssl-certificates
https://blog.andrewsomething.com/2019/04/04/external-dns-with-ssl-on-k8s/
| port: 443 | ||
| targetPort: 5000 | ||
| port: 80 | ||
| targetPort: 80 |
There was a problem hiding this comment.
This app listens on port 80, so we need to update the targetPort.
https://github.com/sharmita3/sample-python/blob/main/server.py#L16
Since we removed the SSL configuration above, we need to change the port to 80 as well.
1 participant
No description provided.