Open
Conversation
Owner
|
Hi @cosmo0920 , thanks for the merge request. |
shivaken
reviewed
Mar 6, 2018
Owner
shivaken
left a comment
shivaken
left a comment
There was a problem hiding this comment.
Just found a small issue. But I need to setup test environment to confirm it.
It would be great if you can check my comment and test with some data.
test/out_better_timestamp.rb
Outdated
| mapped = {} | ||
|
|
||
| msec = 1 | ||
| time = Time.now |
Owner
There was a problem hiding this comment.
This seems to be using time when the plugin receives the log instead of using time stored as @timestamp.
I'm afraid this may generate unexpected value.
Author
There was a problem hiding this comment.
Oops, I misunderstood this test case scenario.
I've fixed it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think that this plugin should work with Fluentd v0.14 on compatible layer.
This plugin still locks Fluentd dependency and does not depends on test-unit for development.
And the biggest issue is using
Engine.emit.It causes raising exception at runtime because Fluentd v0.14 treats it as a bug.