Draft
Conversation
..., and of course add signature-related types. Some `Convert` implementations are still buggy, and are to be fixed in the next several commits. Changelog: detail
`sequoia-openpgp` does not expose the various `parse` methods, so we have to patch it to make them public. Ref: shniubobo/sequoia@e906c1c Changelog: detail
... to stop `wasm-opt` from complaining. The exact reason why this is needed is not known to me. Changelog: detail
`sequoia-openpgp` gives us the embedded signature as one big field, so we need to retrieve field lengths within it with extra steps. Another patch has been done to make this possible. Before this commit, embedded signatures resulted in `Error::SpanNotFound`, and this commit fixes that. Ref: shniubobo/sequoia@aebe70d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has been a lot of work, and it has not been completed yet. Several
Convertimplementations are still buggy, or unimplemented. AndRenderhas not been implemented for those signature types.Todo list
Convertimplementations:gen_bitflags_convert_impls!SignatureSubpacketData::EmbeddedSignatureimpl Convert<pgp::packet::signature::subpacket::SubpacketLength> for SignatureSubpacketLengthsequoia-openpgp, or wait for this issue to be resolvedRenderDisplayimplementations inpacket