Fixed image upload crash and added URL paste support for profile images#229
Open
kushbosamiya wants to merge 2 commits intoshopstr-eng:mainfrom
Open
Fixed image upload crash and added URL paste support for profile images#229kushbosamiya wants to merge 2 commits intoshopstr-eng:mainfrom
kushbosamiya wants to merge 2 commits intoshopstr-eng:mainfrom
Conversation
added 2 commits
February 15, 2026 19:03
…om server response before accessing properties, check HTTP status, added optional URL input for pasting hosted image URLs
- Restrict image URL input to HTTPS-only, aligning validation logic with the error message and enforcing secure URLs for profiles/communities. - Include `size` in Blossom server response validation so incomplete responses are rejected instead of silently falling back to "0".
|
Someone is attempting to deploy a commit to the shopstr-eng Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixing #215
Uploading an image on the shop profile or user profile page crashes with
"Cannot read properties of undefined (reading toString)"
This happens because the blossom server response is used directly without
checking the HTTP status or validating that the expected fields exist.
If the server returns an error or an incomplete response, response.size.toString()
blows up.
Additionally, users who already have images hosted on blossom or any URL
are forced to re-upload them -- there is no way to just paste a URL.
Changes
Bug fix -- blossom upload crash (nostr-helper-functions.ts)
Feature -- paste image URL (file-uploader.tsx)
Wired up URL paste on profile and community forms
Testing