Skip to content

Conversation

@larskemper
Copy link
Member

@larskemper larskemper commented Dec 15, 2025

@larskemper larskemper self-assigned this Dec 15, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR documents version 16.0.0 changes for the Shopware Migration Assistant, resolving issue #12625. The documentation includes comprehensive changelog entries and upgrade instructions for breaking changes.

Key changes:

  • Complete version 16.0.0 changelog with feature descriptions and breaking changes
  • Enhanced README.md with better structure, installation instructions, and developer workflows
  • German changelog updates for consistency with English version

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.

File Description
UPGRADE.md Documents breaking changes for version 16.0.0 with detailed technical migration instructions for error resolution, API changes, and refactorings
README.md Restructured with improved navigation, clearer sections for documentation, requirements, installation, developer setup, and common workflows
CHANGELOG.md Added high-level feature descriptions for version 16.0.0 including error resolution UI, ACL constraints, validation improvements, and CLI command removals
CHANGELOG_de-DE.md German translation of changelog with formatting corrections and consistency improvements

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

- Added new class `SwagMigrationAssistant\Migration\Mapping\Lookup\TaxLookup` to replace the removed method `getTaxUuid`
- Added new class `SwagMigrationAssistant\Migration\Mapping\Lookup\SeoUrlTemplateLookup` to replace the removed method `getSeoUrlTemplateUuid`
- [BREAKING] Added new constructor parameter `LowestRootCategoryLookup $lowestRootCategoryLookup`. `DefaultCmsPageLookup $defaultCmsPageLookup`, `LanguageLookup $languageLookup` to `SwagMigrationAssistant\Profile\Shopware\Converter\CategoryConverter`
- [BREAKING] Added new constructor parameter `LowestRootCategoryLookup $lowestRootCategoryLookup`, `DefaultCmsPageLookup $defaultCmsPageLookup`, `LanguageLookup $languageLookup` to `SwagMigrationAssistant\Profile\Shopware\Converter\CategoryConverter`
Copy link

Copilot AI Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: there's an extra backtick after "lowestRootCategoryLookup". The backtick and comma should be: , not .

Copilot uses AI. Check for mistakes.
- MIG-118 - Korrigiert die Migration der Kredit-Bestellpositionen
- MIG-120 - Behebt ein Problem beim Laden des Premappings
- MIG-162 - Behebt ein Problem bei der Migration von Produkten mit leeren Freitextfeldern
- MIG-162 - Behebt ein Problem bei der Migration von Produkten mit leeren Freitextfeldern
Copy link

Copilot AI Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing whitespace: This line has trailing whitespace that should be removed for consistency.

Copilot uses AI. Check for mistakes.
- PT-11113 - Anpassung der Plugin icons
- PT-11111 - Anpassung des Profilicons für externe Profile
- NTR - Behebt ein Problem nach dem Installieren von extern Profilen
- NTR - Behebt ein Problem nach dem Installieren von extern Profilen
Copy link

Copilot AI Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing whitespace: This line has trailing whitespace that should be removed for consistency.

Copilot uses AI. Check for mistakes.
- `SwagMigrationAssistant\Migration\Logging\LogCannotConvertChildEntity`,
- `SwagMigrationAssistant\Migration\Logging\LogCannotConvertEntity`,
- `SwagMigrationAssistant\Migration\Logging\LogDocumentTypeNotSupported`,
- `SwagMigrationAssistant\Migration\Logging\LogInvalidUnserializedData`,
Copy link

Copilot AI Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate line: Line 179 appears to be a duplicate of the bullet point naming "LogInvalidUnserializedData" which was already mentioned. This line should be removed.

Suggested change
- `SwagMigrationAssistant\Migration\Logging\LogInvalidUnserializedData`,

Copilot uses AI. Check for mistakes.
- Created `SwagMigrationAssistant\Migration\Logging\Log\Builder\MigrationLogBuilder` to build log entries of type `MigrationLogEntry`
- Added columns to `swag_migration_logging` with `SwagMigrationAssistant\Core\Migration\Migration1754897550AddRequiredFieldsToMigrationLogs`:
- `entity_name`
- `entity_id`
Copy link

Copilot AI Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing field in list: The changelog lists "entity_id" as an added column in line 186, but this field is not mentioned in the fields list starting at line 193. For consistency with the UPGRADE documentation pattern, this field should be included in both the columns list and the fields list.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants