feat: prevent multiple connections to the same system #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larskemper
changed the title
larskemper
requested review from
DennisGarding,
MalteJanz,
ennasus4sun,
jozsefdamokos and
vintagesucks
MalteJanz
requested changes
Nov 28, 2025
ennasus4sun
reviewed
Dec 1, 2025
src/Resources/app/administration/src/module/swag-migration/snippet/de.json
Outdated
Show resolved
Hide resolved
…or' into feat/prevent-multiple-connections-to-same-source-shop
ennasus4sun
approved these changes
Dec 3, 2025
jozsefdamokos
approved these changes
Dec 3, 2025
DennisGarding
approved these changes
Dec 3, 2025
…ultiple-connections-to-same-source-shop
vintagesucks
requested changes
Dec 10, 2025
vintagesucks
approved these changes
Dec 12, 2025
MalteJanz
reviewed
Dec 15, 2025
src/Migration/Connection/Fingerprint/MigrationFingerprintService.php
Outdated
Show resolved
Hide resolved
src/Migration/Connection/Fingerprint/Provider/Shopware5FingerprintProvider.php
Outdated
Show resolved
Hide resolved
src/Migration/Connection/Fingerprint/Provider/Shopware5FingerprintProvider.php
Outdated
Show resolved
Hide resolved
…ultiple-connections-to-same-source-shop
MalteJanz
approved these changes
Dec 17, 2025
Contributor
MalteJanz
left a comment
MalteJanz
left a comment
There was a problem hiding this comment.
Besides my comments it looks great now. Thanks for refactoring it another time 💪
src/Resources/app/administration/src/module/swag-migration/store/migration.store.ts
Outdated
Show resolved
Hide resolved
MalteJanz
approved these changes
Dec 17, 2025
larskemper
merged commit a288248
into
feature/migration-logging-refactor
12 checks passed
larskemper
deleted the
feat/prevent-multiple-connections-to-same-source-shop
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves shopware/shopware#13670
SwagMigrationConnector pr: shopware/SwagMigrationConnector#5
This pull request introduces a fingerprinting mechanism for migration connections to prevent duplicate source system connections.
Strategy
Shopware 6
For Shopware 6 connections, we use the
shopIdV2property fromsystem_configas the connection fingerprint. This ID uniquely identifies every Shopware 6 shop.Shopware 5
Since Shopware 5 doesn't have a shopId and the SBP identifies shops by domain, we extract
esdKeyandinstallationDatefroms_core_config_elements, hash them together, and use the resulting hash as the connection fingerprint:esdKey: An automatically generated identifier for Shopware 5 shops, present after initial installation. In Shopware 5, it's used to generate serial numbers for digital products. (Note: Theoretically editable by the shop owner, but this is highly unlikely in practice.)installationDate: The datetime set during the Shopware 5 installation process.=> we can of course use other fields and hash them if you have a idea for more appropriate ones