Skip to content

Conversation

@dallyger
Copy link
Contributor

@dallyger dallyger commented Dec 17, 2025

  • fix(hosting): compose example: add missing service 'init-perm'
  • fix(hosting): compose example: add missing volume definitions
  • fix(hosting): compose example: depends_on database label
  • fix(hosting): compose example: drop build image name

@dallyger dallyger force-pushed the fix-docker-hosting-example branch from 5e1bd90 to b93887b Compare December 17, 2025 15:30
Fixes the following error message on `docker compose up`:

> Error response from daemon: pull access denied for local,
> repository does not exist or may require 'docker login': denied:
> requested access to the resource is denied
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes several issues in the Docker Compose example configuration within the hosting documentation. The changes correct service references, add missing components, and ensure the example configuration is complete and functional.

Key Changes:

  • Added the missing init-perm service for setting file permissions before initialization
  • Fixed the service dependency reference from db to database to match the actual service name
  • Added missing volume definitions that are referenced by services

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +191 to +197
entrypoint: >
chown 82:82
/var/www/html/files
/var/www/html/public/theme
/var/www/html/public/media
/var/www/html/public/thumbnail
/var/www/html/public/sitemap
Copy link

Copilot AI Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The entrypoint command using the YAML multiline string operator > will concatenate all lines into a single line with spaces. This means the command will become chown 82:82 /var/www/html/files /var/www/html/public/theme /var/www/html/public/media /var/www/html/public/thumbnail /var/www/html/public/sitemap which is incorrect syntax for the chown command. The -R flag is missing for recursive directory permissions, and the paths should be passed correctly. Consider using entrypoint: ["chown", "-R", "82:82", "/var/www/html/files", "/var/www/html/public/theme", "/var/www/html/public/media", "/var/www/html/public/thumbnail", "/var/www/html/public/sitemap"] or use a shell command with proper syntax.

Suggested change
entrypoint: >
chown 82:82
/var/www/html/files
/var/www/html/public/theme
/var/www/html/public/media
/var/www/html/public/thumbnail
/var/www/html/public/sitemap
entrypoint: [ "chown", "-R", "82:82", "/var/www/html/files", "/var/www/html/public/theme", "/var/www/html/public/media", "/var/www/html/public/thumbnail", "/var/www/html/public/sitemap" ]

Copilot uses AI. Check for mistakes.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-R was explicitly not added, because I want the initial startup using the example to work, but don't want to touch gigabytes of files each time I restart the container.

The other comment I do not get. What is wrong with the syntax? It works. Does it really need to be the very verbose array syntax? Why? Any links to official docs maybe?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Bugfixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants