This repository was archived by the owner on Mar 28, 2024. It is now read-only.
NTR - Add package.json import paths for admin#83
Open
NiklasLimberg wants to merge 1 commit intomainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes building the administration with vite. Vite complains about every import that doesn't have a corresponding export in the
exportsfield, if such a configuration exists.This solution is certainly not perfect, but it makes vite happy. Ideally we would consolidate our imports in the admin as the node docs recommend, or we should put targeted sub exports in our package.json and those then would be exclusively used.
How to test:
Try to start the watch mode of my vite PoC or search for all imports in the administration and try to find a corresponding entry in the package.json config