Skip to content

PCM #497 #502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
bwhitman wants to merge 32 commits into
base: main
Choose a base branch
from
Open

PCM #497 #502

bwhitman wants to merge 32 commits into from

Conversation

@bwhitman
Copy link
Collaborator

@bwhitman bwhitman commented Dec 21, 2025 •
edited
Loading

Does all the stuff in #497. With tests! And documentation !

@bwhitman bwhitman requested a review from dpwe December 21, 2025 22:17
@bwhitman bwhitman mentioned this pull request Dec 21, 2025
Open
dpwe
dpwe approved these changes Dec 22, 2025
View reviewed changes
Copy link
Collaborator

@dpwe dpwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the code. I was kind of assuming I was reviewing AI-written code which definitely colored my patience. Then I saw the thing where you had summarily rejected the need to scan for largest amplitude in a block, which I guess is not AI. Anyway, I think the code tends to be a bit prolix. It's OK, but it's getting harder to understand - we should simplify to a single pcm_preset_t rather than having separate memorypcm and (ROM) pcm_map_t. But I'm OK with checking this in as long as you make an issue for the tech debt.

@bwhitman
Copy link
Collaborator Author

bwhitman commented Dec 22, 2025

How about the setting max_value to 1 in PCM. Is that correct and that was just normal snark, or something to fix? The issue was samples with blocks of silence stopping too early.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dpwe dpwe dpwe approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bwhitman @dpwe