Skip to content

Update TextInput.js #550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
StephenTANM wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Update TextInput.js #550

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion components/TextInput.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,13 @@ class TextInput extends PureComponent {

handleBlur() {
this.setState({ isFocused: false });
this.props.onBlur()
Copy link
Contributor

@Definitely-Not-Vlad Definitely-Not-Vlad Dec 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Destructure onBlur from this.props on the first line of the method with a fallback to null if it isn't set. This should be followed by a newline. Then check if onBlur is truthy and run it:

handleBlur() {
  const { onBlur = null } = this.props;

  this.setState({ isFocused: false });
  if (onBlur) {
    onBlur();
  }
}

}

handleFocus() {
this.setState({ isFocused: true });
this.props.onFocus()
Copy link
Contributor

@Definitely-Not-Vlad Definitely-Not-Vlad Dec 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Destructure onFocus from this.props on the first line of the method with a fallback to null if it isn't set. This should be followed by a newline. Then check if onFocus is truthy and run it:

handleFocus() {
  const { onFocus = null } = this.props;

  this.setState({ isFocused: true });
  if (onFocus) {
    onFocus();
  }
}

}

render() {
Comment on lines 31 to 32
Copy link
Contributor

@Definitely-Not-Vlad Definitely-Not-Vlad Dec 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reintroduce this newline between handleFocus and render, we separate all methods with a newline.

const {
errorMessage,
Expand Down