feat: add configurable ambient lighting option#103
Open
adeniyii wants to merge 7 commits intoshuding:mainfrom
Open
feat: add configurable ambient lighting option#103adeniyii wants to merge 7 commits intoshuding:mainfrom
adeniyii wants to merge 7 commits intoshuding:mainfrom
Conversation
Add a new 'ambient' option to control the base illumination level of the globe. This allows users to fine-tune the globe's brightness to better blend with their backgrounds. The ambient value defaults to 0.1 to maintain backward compatibility with existing implementations. Users can now set it to lower values (e.g., 0.05 or 0) for darker globes, or higher values for more illumination. Changes: - Add 'ambient' uniform to shader (src/shader.frag) - Expose 'ambient' option in createGlobe with default of 0.1 (src/index.js) - Add 'ambient' to TypeScript definitions (src/index.d.ts) Closes shuding#102
|
@adeniyii is attempting to deploy a commit to the shu Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Owner
|
Thanks for the PR, can you remove the dist/ folder and also update the playground (under website/)? |
adeniyii
force-pushed
the
feat/configurable-ambient-lighting
branch
from
349c961 to
aedc426
Compare
Add interactive slider control for the new ambient lighting option in the playground. Users can now adjust ambient light intensity from 0 to 1 in real-time alongside other lighting controls like diffuse and dark mode.
Author
|
@shuding all done, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new
ambientoption to control the base illumination level of the globe. This allows users to fine-tune the globe's brightness to better blend with their backgrounds.Motivation
Closes #102
Currently, the globe has a hardcoded ambient lighting value of
0.1, which makes it difficult to:Changes
ambientuniform to shader (src/shader.frag)ambientoption increateGlobewith default of0.1(src/index.js)ambientto TypeScript definitions (src/index.d.ts)Backward Compatibility
The default value of
0.1maintains full backward compatibility with existing implementations. No breaking changes.Usage Example
Testing
Tested locally with various ambient values (0, 0.05, 0.1) on both light and dark backgrounds.