Skip to content

Fix settings window layout #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicosuave merged 2 commits into from
Feb 26, 2026
+2 −7
Merged

Fix settings window layout #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
01b20ca
Fix settings window layout by removing empty NSToolbar and using fixe…
nicosuave Feb 26, 2026
0ef3c3a
Remove resizable style from settings window
nicosuave Feb 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions macos/Sources/App/macOS/AppDelegate.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1165,7 +1165,7 @@ class AppDelegate: NSObject,
if settingsWindowController == nil {
let window = SettingsWindow(
contentRect: NSRect(x: 0, y: 0, width: 720, height: 500),
styleMask: [.titled, .closable, .miniaturizable, .resizable],
styleMask: [.titled, .closable, .miniaturizable],
backing: .buffered,
defer: false
)
Expand All @@ -1174,12 +1174,7 @@ class AppDelegate: NSObject,
window.isReleasedWhenClosed = false
window.collectionBehavior = [.moveToActiveSpace]

let toolbar = NSToolbar(identifier: "SettingsToolbar")
toolbar.showsBaselineSeparator = false
window.toolbar = toolbar
window.toolbarStyle = .unified

window.minSize = NSSize(width: 680, height: 450)
window.contentViewController = NSHostingController(rootView: SettingsView())
settingsWindowController = NSWindowController(window: window)
}
Expand Down
2 changes: 1 addition & 1 deletion macos/Sources/Features/Settings/SettingsView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ struct SettingsView: View {
.frame(maxWidth: .infinity, maxHeight: .infinity)
}
.navigationSplitViewStyle(.balanced)
.frame(minWidth: 680, minHeight: 450)
.frame(width: 680, height: 450)
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep settings content resizable with the window

Using a fixed .frame(width: 680, height: 450) on the root NavigationSplitView makes the settings content lock to that exact size, so when users resize the settings window (it is still created with the .resizable style mask in AppDelegate), the split view no longer grows with the window and can leave unused blank space instead of expanding the detail/sidebar layout. This regression was introduced by replacing the previous minimum-size frame and is user-visible whenever the window is resized larger than 680×450.

Useful? React with 👍 / 👎.

}
}

Expand Down
Loading