Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f36f5ead59
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| uvx juv run docs/yardstick_adtech_kitchen_sink.ipynb | ||
| uvx juv run docs/yardstick_looker_demo.ipynb |
There was a problem hiding this comment.
Point notebook commands to existing files
The new notebook workflow commands reference docs/yardstick_adtech_kitchen_sink.ipynb and docs/yardstick_looker_demo.ipynb, but this repository (including commit 9c6c40b) contains no .ipynb files, so users following these instructions will immediately hit a file-not-found error. Please either add the notebooks or update the commands to paths that exist in-tree.
Useful? React with 👍 / 👎.
💡 Codex Reviewhttps://github.com/sidequery/yardstick/blob/5cfa369d8177cd73234b53042db1c566a06ca620/docs/yardstick_adtech_kitchen_sink.ipynb#L4972 This notebook is not valid JSON because the final line contains a literal ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
The DuckDB 1.5.x compatibility work remains in #24.