Skip to content

Fix Composite Class and Filenames #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ralienpp merged 4 commits into from
Jan 7, 2026
Merged

Fix Composite Class and Filenames #38

ralienpp merged 4 commits into from
Jan 7, 2026

Conversation

@Guiliano99
Copy link
Contributor

@Guiliano99 Guiliano99 commented Dec 13, 2025

Change the Composite-KEM and -Sig class and file names.

Description

  • Renamed the composite_sig.py and composite_kem.py files by removing the version suffixes.
  • Removed version from the corresponding public and private key classes.
  • Removed version from all related test case names.

Motivation and Context

  • Improves overall readability and maintainability of the class implementations by eliminating unnecessary version identifiers.

ToDo

  • Determine whether to update the string identifiers as well.
  • Assess whether OID names must remain unchanged for correct lookup behavior.

How Has This Been Tested?

Validated through the pipeline.

@Guiliano99
Change Composite-Sig class- and filename.
a8e0195 
- Remove the version name of the class and the file.
- Done for fewer changes if the version is updated.
@Guiliano99
Remove version from Composite-Sig test file names.
3713a0b
@Guiliano99
Change Composite-KEM class- and filename.
7712713 
- Remove the version name of the class and the file.
- Done for fewer changes if the version is updated.
@Guiliano99
Change Composite KEM test case names.
e955744 
- By removing the version name.
@Guiliano99 Guiliano99 requested a review from ralienpp as a code owner December 13, 2025 07:53
@ralienpp ralienpp merged commit 2b660cd into siemens:main Jan 7, 2026
8 of 10 checks passed
@Guiliano99 Guiliano99 deleted the Fix-Composite-Names branch January 8, 2026 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ralienpp ralienpp Awaiting requested review from ralienpp ralienpp is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Guiliano99 @ralienpp