Skip to content

Conversation

@kathrinschalber
Copy link
Collaborator

@kathrinschalber kathrinschalber commented Oct 22, 2025

💡 What is the current behavior?

See jira ticket

Jira Issue Number: IX-3499

🆕 What is the new behavior?

  • Clearly describe the 3 types of cards (also the normal card)
  • Update the images
  • For breadcrumb, rename option from subtle to secondary

👨‍💻 Help & support

  • Gemini review
  • UX review
  • Dev review
  • Final edit

Corrected breadcrumb appearance terminology from 'Ghost' to 'Subtle'. Expanded and clarified card documentation: restructured card types, updated images, detailed options and behaviors, and specified sizing for action and push cards.
Revised the card documentation to clarify card types, update descriptions, and improve structure. Updated and added Figma illustration assets to reflect the new elevation colors and correct types.
@netlify
Copy link

netlify bot commented Oct 22, 2025

Deploy Preview for industrial-experience ready!

Name Link
🔨 Latest commit de3482a
🔍 Latest deploy log https://app.netlify.com/projects/industrial-experience/deploys/690232cb8bab190008b1cce3
😎 Deploy Preview https://deploy-preview-119--industrial-experience.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

kathrinschalber and others added 4 commits October 22, 2025 12:50
Enhanced the formatting of card types and their descriptions for better readability. Clarified distinctions between card variants, updated guidelines for card sizing, and improved instructions for grouping cards in lists or grids.
@kathrinschalber
Copy link
Collaborator Author

/gemini review

@kathrinschalber kathrinschalber removed the request for review from flxlst09 October 27, 2025 15:35
@kathrinschalber kathrinschalber marked this pull request as ready for review October 27, 2025 15:35
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the documentation for the Card and Breadcrumb components, improving clarity and structure. The changes for the Card component, in particular, provide a better overview of the different card types and reorganize the options for better readability. My review includes several suggestions to further align the documentation with the repository's style guide, focusing on using suggestive language instead of commands, correcting minor formatting issues, and ensuring consistency in descriptions.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Copy link
Collaborator

@flxlst09 flxlst09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy to grasp, helps understanding the different cards 👍. Main topic for me is the information-dense first illustration. See comments.

Replaced and added new Figma illustration links in the card component guide for better clarity. Updated and added corresponding image assets in the static/figma directory. Also clarified card placement guidance in the documentation.
@kathrinschalber
Copy link
Collaborator Author

@AndreasBerliner I've added you as reviewer from dev side. If everything is fine from your side, please assign it to @tokyojen for final edit 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants