-
Notifications
You must be signed in to change notification settings - Fork 11
Docs/update card and breadcrumb #119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Corrected breadcrumb appearance terminology from 'Ghost' to 'Subtle'. Expanded and clarified card documentation: restructured card types, updated images, detailed options and behaviors, and specified sizing for action and push cards.
Revised the card documentation to clarify card types, update descriptions, and improve structure. Updated and added Figma illustration assets to reflect the new elevation colors and correct types.
✅ Deploy Preview for industrial-experience ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Enhanced the formatting of card types and their descriptions for better readability. Clarified distinctions between card variants, updated guidelines for card sizing, and improved instructions for grouping cards in lists or grids.
…siemens/ix-docs into docs/update-card-and-breadcrumb
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the documentation for the Card and Breadcrumb components, improving clarity and structure. The changes for the Card component, in particular, provide a better overview of the different card types and reorganize the options for better readability. My review includes several suggestions to further align the documentation with the repository's style guide, focusing on using suggestive language instead of commands, correcting minor formatting issues, and ensuring consistency in descriptions.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Easy to grasp, helps understanding the different cards 👍. Main topic for me is the information-dense first illustration. See comments.
Replaced and added new Figma illustration links in the card component guide for better clarity. Updated and added corresponding image assets in the static/figma directory. Also clarified card placement guidance in the documentation.
|
@AndreasBerliner I've added you as reviewer from dev side. If everything is fine from your side, please assign it to @tokyojen for final edit 😊 |
💡 What is the current behavior?
See jira ticket
Jira Issue Number: IX-3499
🆕 What is the new behavior?
👨💻 Help & support