Fuse_daemon: Always attempt to clear out stale mounts before mounting#1749
Draft
Nathan Graybeal (ngraybeal) wants to merge 1 commit intomasterfrom
Draft
Fuse_daemon: Always attempt to clear out stale mounts before mounting#1749Nathan Graybeal (ngraybeal) wants to merge 1 commit intomasterfrom
Nathan Graybeal (ngraybeal) wants to merge 1 commit intomasterfrom
Conversation
Nathan Graybeal (ngraybeal)
requested review from
Abrar Quazi (AbrarQuazi),
Sam May (ag-eitilt) and
Will Dietz (dtzSiFive)
| #ifndef __APPLE__ | ||
| // Attempt to lazily unmount a stale mount point (fails silently if not mounted) | ||
| static void try_unmount_stale(const char *path, bool debug) { | ||
| std::string cmd = "fusermount -uz '" + std::string(path) + "' 2>/dev/null"; |
Contributor
There was a problem hiding this comment.
Any way we can check if a fuse mount exists before unmounting it?
Contributor
Author
There was a problem hiding this comment.
Yeah you can do mountpoint. The only reason to do that is if we care about catching fusermount-uz failures. Otherwise, fusermount -uz just basically makes the same check and exits if it's not.
| try_unmount_stale(path.c_str(), debug); | ||
| #endif | ||
|
|
||
| fc = fuse_mount(path.c_str(), &args); |
Contributor
There was a problem hiding this comment.
Any race conditions that can happen when we unmount and then immediately try to mount? What if the mount is still cleaning up?
Contributor
Author
There was a problem hiding this comment.
I don't believe so. The -z should be immediate allowing a new mount to land.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create a persistant daemon started by Wake runtime, instead of wakebox to reduce the up/downtime costs and possible flakiness of those actions.