multi-wake: remove .wake-build-lock mechanism#1761
Open
Will Dietz (dtzSiFive) wants to merge 2 commits intosifiveinc:feature/multi-wakefrom
Open
multi-wake: remove .wake-build-lock mechanism#1761Will Dietz (dtzSiFive) wants to merge 2 commits intosifiveinc:feature/multi-wakefrom
Will Dietz (dtzSiFive) wants to merge 2 commits intosifiveinc:feature/multi-wakefrom
Conversation
Will Dietz (dtzSiFive)
requested review from
Abrar Quazi (AbrarQuazi),
Sam May (ag-eitilt) and
Nathan Graybeal (ngraybeal)
Will Dietz (dtzSiFive)
changed the base branch from
master
to
feature/multi-wake
The schema had 'update entropy set seed=0 where 0;' which was used to acquire an exclusive lock on database open, preventing any concurrent access. This is no longer needed with proper transaction handling.
Will Dietz (dtzSiFive)
force-pushed
the
pr/remove-build-lock
branch
from
d7f5998 to
4e56cb2
Compare
The file-based build lock prevented concurrent wake invocations. This is no longer needed, remove it!
Will Dietz (dtzSiFive)
force-pushed
the
pr/remove-build-lock
branch
from
4e56cb2 to
4b90964
Compare
Sam May (ag-eitilt)
approved these changes
Apr 21, 2026
Collaborator
Sam May (ag-eitilt)
left a comment
Sam May (ag-eitilt)
left a comment
There was a problem hiding this comment.
Pretty sure this should be able to work (obviously after #1760) even without any of the other multi-wake/CAS changes; sorry I didn't review earlier to have allowed it to be rolled into v48.
Nathan Graybeal (ngraybeal)
approved these changes
Apr 21, 2026
Contributor
Nathan Graybeal (ngraybeal)
left a comment
Nathan Graybeal (ngraybeal)
left a comment
There was a problem hiding this comment.
LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The file-based build lock prevented concurrent wake invocations.
This is no longer needed, remove it!
Remove entropy table exclusive lock in schema.
Should land at least after #1760 .