feature: add get_song_credits (#883)#884
Open
cedrikewers wants to merge 2 commits intosigma67:mainfrom
Open
Conversation
- Adds the new function get_song_credits to fetch the credits of a song. Credits have their own browseId that identifies the request. - Updates the parse_playlist_item parser to return the browseId of the credits request in the response of get_album and get_playlist
The previous playlist is now unavailable, so i replaced it with another very long playlist.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
get_song_creditsto fetch the credits of a song. Credits have their own browseId prefixed byMPTC.parse_playlist_itemparser to return thebrowseIdfor the credits of a song in the response ofget_albumand `get_playlist.Failing tests:
test_search_ignore_spellingfinds this relatively new playlist which seems to have corrupt metadata on YouTube's site? The duration is listed as "0+" hoursFeature Request: #883