test: add seeded message delivery shuffling to QBFT tests#906
Open
diegomrsantos wants to merge 1 commit intosigp:unstablefrom
Open
test: add seeded message delivery shuffling to QBFT tests#906diegomrsantos wants to merge 1 commit intosigp:unstablefrom
diegomrsantos wants to merge 1 commit intosigp:unstablefrom
Conversation
Explore different network interleavings by shuffling operator delivery order with a seeded RNG. Same seed = same ordering = reproducible. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem, Evidence, and Context (Required)
Change Overview (Required)
QbftTestergains an optional seeded RNG that shuffles operator delivery order inprocess_network_message. When a seed is provided, each message broadcast delivers to operators in a different (but reproducible) shuffled order.TestContext::new_seeded()threads the seed through for ergonomic test construction.Nonefor seed, preserving fixed-order delivery).Risks, Trade-offs, and Mitigations (Required)
Validation (Required)
make cargo-fmt-check,make lintclean.Rollback (Required for behavior or runtime changes; optional otherwise)
N/A — test-only change, safe to revert.
Additional Info / Next Steps (Optional)