Skip to content

Conversation

@notiflux
Copy link

Right now, the sr_analog_init-function is called after the data is transferred to the struct, which overwrites it with zeros again. As a result, data aquisition is not possible with this driver. This PR moves the sr_analog_init-call to before the data transfer.

Also, R&S oscilloscopes don't support enabling or disabling individual logic channels, some don't even support enabling or disabling PODs. I implemented a flag system that allows disabling of such capabilities per device, let me know if you think this should be solved differently though.

Finally, i changed the data output format to MAX, which allows to transfer the entire oscilloscope memory contents (otherwise, data is downsampled according to the horizontal zoom settings). This only works while aquisition is stopped on the device, otherwise it falls back to the default output format. This way, data aquisition is still just as fast while the scope is in RUN mode, but is also able to aquire large data blocks while it's stopped (much slower).

Copy link

@Krakonos Krakonos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abraxa I have reviewed the code and while I don't have any of the supported devices for testing, the changes are very reasonable and should not cause issues. The scope of the changes is nicely described in the PR comment and alight with the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants