Add OCI 1.1 referrers API support for attestation discovery #1894
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
falcorocks
force-pushed
the
falcorocks/add-oci11-support
branch
2 times, most recently
from
751857e to
f0a9af2
Compare
Implements OCI 1.1 referrers API for discovering attestations with automatic fallback to legacy tag-based discovery. This enables policy-controller to work with modern OCI 1.1 registries while maintaining backward compatibility. - Add 'enable-oci11' configuration option (disabled by default) - Implement OCI 1.1 referrers API discovery with fallback - Add CLI flag '--enable-oci11' to policy-tester for testing Signed-off-by: falcorocks <14293929+falcorocks@users.noreply.github.com>
falcorocks
force-pushed
the
falcorocks/add-oci11-support
branch
from
f0a9af2 to
9962aa2
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1894 +/- ##
===========================================
- Coverage 42.78% 29.28% -13.50%
===========================================
Files 121 122 +1
Lines 8994 7320 -1674
===========================================
- Hits 3848 2144 -1704
- Misses 4791 4944 +153
+ Partials 355 232 -123 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
@falcorocks There are some lint issues here. Could you fix those ? |
Fix linting error by changing att.Cert() to att.Signature.Cert() since attestation embeds oci.Signature as a named field. Also remove trailing whitespace. Signed-off-by: falcorocks <14293929+falcorocks@users.noreply.github.com>
falcorocks
force-pushed
the
falcorocks/add-oci11-support
branch
from
5551644 to
b99f840
Compare
Author
|
@hectorj2f I still want to do this, just hard to find the time lately. Please bear with me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1895
Summary
Some provenance attestation implementation, for instance Google Cloud Build, store attestations using the OCI 1.1 referrers API rather than the traditional
<subject digest>.attnaming scheme. As is, the policy controller is thus unable to verify valid in-toto provenance attestations generated by Google Cloud Build. This is demonstrated in #1895.This PR Implements OCI 1.1 referrers API for discovering attestations with automatic fallback to legacy tag-based discovery. This enables policy-controller to work with modern OCI 1.1 registries while maintaining backward compatibility, regardless if the new sigstore bundle format is used or not.
Technical implementation:
BEFORE
AFTER
Release Note
Documentation