VER-748: ath12k: fix corrupted RSSI values#73
Merged
adrian-nicolau merged 5 commits intotg-v6.18-ath12k-nextfrom Mar 3, 2026
Merged
Conversation
shmuelhazan
approved these changes
Mar 3, 2026
adrian-nicolau
deleted the
VER-748-RSSI-values-read-from-kernel-are-incorrect
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gregkh@0314ee8 enhanced the noise floor calculation based on individual temperature and conversion sub-TLVs, but a print inside
ath12k_wmi_update_rssi_offsetsrevealed garbage for the latter:This happens because, as the original commit mentions, the individual TLVs may not always be present in each event, and in this case
WMI_TAG_RSSI_DBM_CONVERSION_TEMP_OFFSET_INFOis present, butWMI_TAG_RSSI_DBM_CONVERSION_PARAMS_INFOis not, thereforemin_nf_dbmcontains stack garbage afterath12k_wmi_rssi_dbm_conv_info_evt_subtlv_parser.