Skip to content

Upgraded lots of DLLs and added Analytics events#898

Draft
tombogle wants to merge 1 commit intomasterfrom
update-dlls-improve-analytics
Draft

Upgraded lots of DLLs and added Analytics events#898
tombogle wants to merge 1 commit intomasterfrom
update-dlls-improve-analytics

Conversation

@tombogle
Copy link
Copy Markdown
Contributor

@tombogle tombogle commented Jan 30, 2026

Jettisoned DotNetZip.
Added Analytics events for starting a new project and other major user actions.
Minor code refactoring.


This change is Reviewable

Added Analytics events
Minor code refactoring
@tombogle tombogle requested a review from andrew-polk January 30, 2026 19:39
@tombogle tombogle self-assigned this Jan 30, 2026
@tombogle tombogle added enhancement dependencies Pull requests that update a dependency file labels Jan 30, 2026
Copy link
Copy Markdown
Contributor

@andrew-polk andrew-polk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrew-polk reviewed 39 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @tombogle).


Glyssen/MainForm.cs line 1051 at r1 (raw file):

				using (var dlg = new AssignCharacterDlg(viewModel))
				{
					TrackAnalyticsForMajorActivity(dlg);

devinreview says

Inconsistent analytics tracking timing across dialog invocations

There's an inconsistency in when TrackAnalyticsForMajorActivity is called:

  • In ShowModalDialogWithWaitCursor (MainForm.cs:354-355): Called AFTER ShowDialog() and only if result != Cancel
  • In Assign_Click (MainForm.cs:1051): Called BEFORE ShowDialog(), unconditionally
  • In Settings_Click (MainForm.cs:1151): Called AFTER ShowDialog() and only if result == OK

This means Assign_Click will track analytics even if the user immediately cancels, while other dialogs only track on completion. This may be intentional (tracking that the dialog was opened vs. completed), but the inconsistency could affect analytics interpretation.


Glyssen/MainForm.cs line 1118 at r1 (raw file):

			var name = (uiElement as Control)?.Name ?? (uiElement as ToolStripItem)?.Name;
			if (name == null)
				throw new ArgumentException(nameof(uiElement), "Expected a UI element with a name");

devinreview points out the parameter order is backwards.

Here's an example of a way that AI review is better than human review. I didn't/wouldn't have caught it.

@tombogle tombogle changed the title Upgraded lots of DLLs and added Analytics eventsd\ Upgraded lots of DLLs and added Analytics events Feb 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants