Skip to content

Enhance ux for verification code in the email#34

Open
jaeminlee0515 wants to merge 2 commits intosillsdev:mainfrom
jaeminlee0515:feature-enhance-verification-email
Open

Enhance ux for verification code in the email#34
jaeminlee0515 wants to merge 2 commits intosillsdev:mainfrom
jaeminlee0515:feature-enhance-verification-email

Conversation

@jaeminlee0515
Copy link
Contributor

Allow for a bigger and more vivid representation of the verification code in the email.
Screenshot 2024-03-23 at 6 40 43 PM

@vercel
Copy link

vercel bot commented Mar 23, 2024

@jaeminlee0515 is attempting to deploy a commit to the Sharon's projects Team on Vercel.

A member of the Team first needs to authorize it.

@jaeminlee0515 jaeminlee0515 marked this pull request as draft March 23, 2024 22:41
@mla04762
Copy link
Contributor

I think it might be better to just replace the heading with the code instead of having the word "Verification" twice.

@jaeminlee0515
Copy link
Contributor Author

I think it might be better to just replace the heading with the code instead of having the word "Verification" twice.

Screenshot 2024-03-26 at 10 02 27 AM

How does this look?

@jaeminlee0515 jaeminlee0515 requested a review from chrisvire March 26, 2024 14:09
@jaeminlee0515 jaeminlee0515 marked this pull request as ready for review March 26, 2024 14:10
@chrisvire
Copy link
Member

@jaeminlee0515 Lint fails.

</p>
<p>
This verification code will expire in 1 hour. -From Team SIL
-From Team SIL
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not needed. Please remove. Realistically, the user using this website doesn't know anything about SIL, but the app that was published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants