Fixed problem in MergeChapter where book number was being treated as an index#309
Open
Fixed problem in MergeChapter where book number was being treated as an index#309
Conversation
Contributor
Author
|
Even with this fix, after synchronizing, HT Android crashes and can't display the project. See HT-488 |
andrew-polk
reviewed
Feb 27, 2025
Contributor
andrew-polk
left a comment
andrew-polk
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @tombogle)
Contributor
Author
|
Since this is clearly a bug, I'm going to go ahead and plan to merge this fix even though it doesn't ultimately solve the full issue with HT-488. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seems to maybe be an issue that only affects glyssenscript projects.
This change is