Skip to content

Conversation

Copy link

Copilot AI commented Oct 28, 2025

Adds a part of speech filter to the browse view, matching the visual design of the existing semantic domain filter.

image

The collapsible filter section also now has a max-height and scrolls, so it doesn't hog the whole screen:
image

@coderabbitai
Copy link

coderabbitai bot commented Oct 28, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Comment @coderabbitai help to get the list of available commands and usage tips.

Copilot AI changed the title [WIP] Add part of speech filter to interface Add part of speech filter Oct 28, 2025
Copilot finished work on behalf of myieye October 28, 2025 16:36
Copilot AI requested a review from myieye October 28, 2025 16:36
Copy link
Collaborator

@myieye myieye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "Part of speech" field is called "Grammatical info." in the "FieldWorks (Classic)" view.
You used the correct terminology for the FieldWorks Lite view, but need to adapt the FieldWorks (Classic) view.

Please find a good way to use that terminology where you're currently referring to "Parts of speech".

@myieye
Copy link
Collaborator

myieye commented Oct 28, 2025

@copilot see my review

Copy link
Author

Copilot AI commented Oct 28, 2025

The "Part of speech" field is called "Grammatical info." in the "FieldWorks (Classic)" view.
You used the correct terminology for the FieldWorks Lite view, but need to adapt the FieldWorks (Classic) v...

Updated to use view-based terminology in commit 8dccced:

  • Filter label: "Grammatical info." (Classic) / "Part of speech" (Lite)
  • Placeholder: "Any grammatical info." (Classic) / "Any part of speech" (Lite)

This matches the terminology used in SenseEditorPrimitive.svelte.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • fonts.googleapis.com
    • Triggering command: node /home/REDACTED/work/languageforge-lexbox/languageforge-lexbox/frontend/viewer/node_modules/.bin/../vite/bin/vite.js build (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI requested a review from myieye October 28, 2025 19:13
Copilot finished work on behalf of myieye October 28, 2025 19:13
@github-actions github-actions bot added the 💻 FW Lite issues related to the fw lite application, not miniLcm or crdt related label Oct 29, 2025
@github-actions
Copy link

github-actions bot commented Oct 29, 2025

UI unit Tests

  1 files  ±0   45 suites  ±0   28s ⏱️ -1s
111 tests ±0  111 ✅ ±0  0 💤 ±0  0 ❌ ±0 
160 runs  ±0  160 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 5a86f84. ± Comparison against base commit fa40eb4.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 29, 2025

C# Unit Tests

130 tests  ±0   130 ✅ ±0   20s ⏱️ ±0s
 20 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 5a86f84. ± Comparison against base commit fa40eb4.

♻️ This comment has been updated with latest results.

Copilot AI and others added 10 commits October 29, 2025 17:07
Co-authored-by: myieye <12587509+myieye@users.noreply.github.com>
Co-authored-by: myieye <12587509+myieye@users.noreply.github.com>
Use "Grammatical info." for FieldWorks Classic view and "Part of speech" for FieldWorks Lite view in both the filter label and placeholder text.

Co-authored-by: myieye <12587509+myieye@users.noreply.github.com>
@myieye myieye force-pushed the copilot/add-part-of-speech-filter branch from 41084f2 to 5a86f84 Compare October 29, 2025 16:07
@myieye myieye marked this pull request as ready for review October 29, 2025 16:08
Copy link
Collaborator

@myieye myieye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran into a little bit of scope creep as I found various nuisances, imperfections in our select components.

@argos-ci
Copy link

argos-ci bot commented Oct 29, 2025

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No changes detected - Oct 29, 2025, 4:23 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

💻 FW Lite issues related to the fw lite application, not miniLcm or crdt related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants