-
-
Notifications
You must be signed in to change notification settings - Fork 5
Add part of speech filter #2079
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "Part of speech" field is called "Grammatical info." in the "FieldWorks (Classic)" view.
You used the correct terminology for the FieldWorks Lite view, but need to adapt the FieldWorks (Classic) view.
Please find a good way to use that terminology where you're currently referring to "Parts of speech".
|
@copilot see my review |
Updated to use view-based terminology in commit 8dccced:
This matches the terminology used in Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Co-authored-by: myieye <12587509+myieye@users.noreply.github.com>
Co-authored-by: myieye <12587509+myieye@users.noreply.github.com>
Use "Grammatical info." for FieldWorks Classic view and "Part of speech" for FieldWorks Lite view in both the filter label and placeholder text. Co-authored-by: myieye <12587509+myieye@users.noreply.github.com>
41084f2 to
5a86f84
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ran into a little bit of scope creep as I found various nuisances, imperfections in our select components.
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
Adds a part of speech filter to the browse view, matching the visual design of the existing semantic domain filter.
The collapsible filter section also now has a max-height and scrolls, so it doesn't hog the whole screen:
