Windows static build: COMPILE_DEFINITIONS: GRAPHITE2_STATIC#56
Open
spl wants to merge 1 commit intosilnrsi:masterfrom
Open
Windows static build: COMPILE_DEFINITIONS: GRAPHITE2_STATIC#56spl wants to merge 1 commit intosilnrsi:masterfrom
spl wants to merge 1 commit intosilnrsi:masterfrom
Conversation
|
applied in #69 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the
COMPILE_DEFINITIONSfromGRAPHITE2_EXPORTINGtoGRAPHITE2_STATICfor static builds on Windows (whenBUILD_SHARED_LIBSisOFF).I just wanted to leave this here in case it's helpful. I don't have an example of this change fixing anything, but it seems like the right thing to do. Also, I'm not very proficient with CMake, so there may be a better way to do this that reduces the redundancy.