Add null loggers #172
Draft
Add null loggers #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cviebrock
force-pushed
the
add-null-loggers
branch
from
b4f2018 to
2bfb7e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
SwatNullExceptionLoggerandSwatNullErrorLoggerclasses: implementations of the loggers that don't actually log anywhere.Also adds the ability to clear out all the configured exception/error loggers.
This will save some conditional logic in downstream applications.
Note
The changes to
composer.lockandSwatDB.phpare unrelated to this PR. It looks like Jenkins was erasing the lock file during CI, which meant that a new minor version of PHP-CS would get installed ... and then CI would fail because the formatting rules would have slightly changed.I erased and rebuilt the lock file (based on current package versions), fixed the one styling issue that CI identified due to the new PHP-CS version, and then updated the
Jenkinsfileto not do this again.