Phpstan level 1 issues

[cviebrock]

Fixes all level 1 issues and those that are caught with checkFunctionArgumentTypes: true

... with one exception that I'm sure how best to fix:

 ------ --------------------------------------------------------------------------------- 
  Line   Swat/SwatCascadeFlydown.php                                                      
 ------ --------------------------------------------------------------------------------- 
  169    Parameter #2 $title of class SwatOption constructor expects string, null given.  
         🪪 argument.type                                                                 
         ✏️ Swat/SwatCascadeFlydown.php:169                                               
 ------ --------------------------------------------------------------------------------- 

Instead of doing $options = [new SwatOption(null, null)]; could we just do $options = [];? If not, then we would need to change the constructor of SwatOption to allow a null title.

✅ Switched to use SwatOption(null, '') now as it matches other places in the code.

 ------ ---------------------------------------- 
  Line   Swat/SwatTableViewInputRow.php          
 ------ ---------------------------------------- 
  680    Variable $column might not be defined.  
         🪪 variable.undefined                   
         ✏️ Swat/SwatTableViewInputRow.php:680   
 ------ ---------------------------------------- 

❓ My guess is that somewhere in SwatTableViewInputRow::displayEnterAnotherRow() we should return early (and not output anything?) if $columns is empty.

[fokked]

https://app.shortcut.com/silverorangeinc/story/74588/increase-php-stan-to-next-level-on-swat-and-address-errors

[gauthierm]

Instead of doing $options = [new SwatOption(null, null)]; could we just do $options = [];? If not, then we would need to change the constructor of SwatOption to allow a null title.

I think we have a blank option for browser compatibility. At the time it was written, it's likely that a select with no elements did not render properly. The code in SwatFlydown will only render a select if there are >= 1 options.

[cviebrock]

Then I'd suggest we do the same thing as we do when we want a blank option, and just do new SwatOption(null, '') (or maybe even SwatFlydownBlankOption(null, '')?)

[gauthierm]

cviebrock#2